bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Use preventDefault instead of stopPropagation"

Browse Source
This commit is contained in:
jenkins-bot
2014-03-27 08:26:06 +00:00
committed by Gerrit Code Review
parent e72df2dbb9 62939949b4
commit 0a98d2f381
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
resources/js/ext.uls.interface.js
View File

@@ -397,6 +397,8 @@
$ulsTrigger.on( 'click', function ( e, eventParams ) { $ulsTrigger.on( 'click', function ( e, eventParams ) {
var languagesettings = $ulsTrigger.data( 'languagesettings' ); var languagesettings = $ulsTrigger.data( 'languagesettings' );
e.preventDefault();
if ( languagesettings ) { if ( languagesettings ) {
if ( !languagesettings.shown ) { if ( !languagesettings.shown ) {
mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' ); mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' );
@@ -407,14 +409,14 @@
$ulsTrigger.trigger( 'click', eventParams ); $ulsTrigger.trigger( 'click', eventParams );
} ); } );
e.stopPropagation();
} }
} ); } );
} else { } else {
$ulsTrigger.on( 'click', function ( e, eventParams ) { $ulsTrigger.on( 'click', function ( e, eventParams ) {
var uls = $ulsTrigger.data( 'uls' ); var uls = $ulsTrigger.data( 'uls' );
e.preventDefault();
if ( uls ) { if ( uls ) {
if ( !uls.shown ) { if ( !uls.shown ) {
mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' ); mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' );
@@ -445,8 +447,6 @@
window.setTimeout( function () { window.setTimeout( function () {
$ulsTrigger.trigger( 'click', eventParams ); $ulsTrigger.trigger( 'click', eventParams );
}, 0 ); }, 0 );
e.stopPropagation();
} ); } );
} }
} ); } );