Simplify by using native JavaScript instead of jQuery

Change-Id: I2ca5fbb21ac473f482579a944e5ab68c9374191c
This commit is contained in:
Fomafix
2018-09-01 08:57:17 +02:00
committed by jenkins-bot
parent 295527552f
commit 0fbdbc2c41
4 changed files with 15 additions and 23 deletions

View File

@@ -210,14 +210,12 @@
* @param {jQuery} $trigger Element to use as trigger.
*/
CompactInterlanguageList.prototype.createSelector = function ( $trigger ) {
var languages,
var languages = Object.keys( this.interlanguageList ),
self = this,
ulsLanguageList = {};
languages = $.map( this.interlanguageList, function ( language, languageCode ) {
ulsLanguageList[ languageCode ] = language.autonym;
return languageCode;
languages.forEach( function ( languageCode ) {
ulsLanguageList[ languageCode ] = this.interlanguageList[ languageCode ].autonym;
} );
// Attach ULS to the trigger
@@ -329,9 +327,7 @@
var language, languages, compactLanguages, i,
compactedList = {};
languages = $.map( this.interlanguageList, function ( item, languageCode ) {
return languageCode;
} );
languages = Object.keys( this.interlanguageList );
compactLanguages = this.compact( languages );

View File

@@ -456,7 +456,7 @@
// Get the saved font using the fontSelector defined in mw.webfonts.setup
savedFont = this.$webfonts.getFont( language );
$.each( fonts, function ( key, font ) {
fonts.forEach( function ( font ) {
var $fontOption;
if ( font !== 'system' ) {

View File

@@ -105,18 +105,14 @@
// Get the name of all registered modules and list them in left side menu.
// Sort the modules based on id
modules = $.map( $.fn.languagesettings.modules, function ( element, index ) {
return index;
} ).sort();
$.each( modules, function ( index, moduleName ) {
if ( $.fn.languagesettings.modules.hasOwnProperty( moduleName ) ) {
if ( !defaultModule ) {
defaultModule = moduleName;
}
// Call render function on the current setting module.
languageSettings.initModule( moduleName, defaultModule === moduleName );
modules = Object.keys( $.fn.languagesettings.modules ).sort();
modules.forEach( function ( moduleName ) {
if ( !defaultModule ) {
defaultModule = moduleName;
}
// Call render function on the current setting module.
languageSettings.initModule( moduleName, defaultModule === moduleName );
} );
},

View File

@@ -40,9 +40,9 @@
$langselector = $( 'select#language' );
function listFonts( fonts ) {
$.merge( fonts, [ 'Sans', 'Serif' ] );
fonts.push( 'Sans', 'Serif' );
$fontSelector.find( 'option' ).remove();
$.each( fonts, function ( key, font ) {
fonts.forEach( function ( font ) {
$fontSelector.append( $( "<option></option>" )
.attr( "value", font ).text( font ) );
} );
@@ -50,7 +50,7 @@
}
listFonts( fonts );
$.each( languages, function ( lang, language ) {
languages.forEach( function ( language ) {
$langselector.append( $( "<option></option>" )
.attr( 'value', language )
.text( language + " - " + $.uls.data.getAutonym( language ) ) );