bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup

Browse Source 
whitepace, unwanted fixmes, wrong comments, jshint

Change-Id: I571b2b3a7e9fbbe7c93262ee9783fbe334d9170e
This commit is contained in:
Santhosh Thottingal
2012-10-29 14:27:40 +05:30
parent fc4ca9f823
commit 1c72077c89
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
resources/js/ext.uls.displaysettings.js
View File

@@ -84,7 +84,7 @@
+ '<button id="uls-displaysettings-apply" class="active blue button" data-i18n="ext-uls-language-settings-apply"></button>' + '<button id="uls-displaysettings-apply" class="active blue button" data-i18n="ext-uls-language-settings-apply"></button>'
+ '</div>' + '</div>'
+ '</div>' + '</div>'
+ '</div>'; // FIXME i18n and too much hardcoding. + '</div>';
function DisplaySettings( $parent ) { function DisplaySettings( $parent ) {
this.name = $.i18n( 'ext-uls-display-settings-title-short' ); this.name = $.i18n( 'ext-uls-display-settings-title-short' );

6
resources/js/ext.uls.ime.js
View File

@@ -1,5 +1,5 @@
/** /**
* ULS-Webfonts integration * ULS - jQuery IME integration
* *
* Copyright (C) 2012 Alolita Sharma, Amir Aharoni, Arun Ganesh, Brandon Harris, * Copyright (C) 2012 Alolita Sharma, Amir Aharoni, Arun Ganesh, Brandon Harris,
* Niklas Laxström, Pau Giner, Santhosh Thottingal, Siebrand Mazeland and other * Niklas Laxström, Pau Giner, Santhosh Thottingal, Siebrand Mazeland and other
@@ -40,7 +40,7 @@
return availableLanguages; return availableLanguages;
}; };
mw.ime.getIMELanguageList = function () { mw.ime.getIMELanguageList = function () {
var unique = [], var unique = [],
imeLanguageList, imeLanguageList,
previousIMELanguages; previousIMELanguages;
@@ -103,7 +103,7 @@
} }
} ); } );
$.ime.preferences.load(); $.ime.preferences.load();
} ); } );

6
resources/js/ext.uls.inputsettings.js
View File

@@ -129,11 +129,9 @@
'class': 'imelabel' 'class': 'imelabel'
} ); } );
// TODO Niklas: Was there some problems with IE needing the type=foo immediately? $inputMethodItem = $( '<input type="radio">' ).attr( {
$inputMethodItem = $( '<input>' ).attr( {
name: 'ime', name: 'ime',
id: imeId, id: imeId,
type: 'radio',
value: imeId, value: imeId,
checked: selected checked: selected
} ); } );
@@ -322,7 +320,7 @@
that.close(); that.close();
} ); } );
$imeListContainer.on( 'change', 'input:radio[name=ime]:checked', function () { $imeListContainer.on( 'change', 'input:radio[name=ime]:checked', function () {
var ime = $( this ).val(); var ime = $( this ).val();
$.ime.preferences.setLanguage( that.imeLanguage ); $.ime.preferences.setLanguage( that.imeLanguage );