bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add type hints to used objects and arrays in hooks

Browse Source 
Also mark only local used functions as private function.

Change-Id: I5fa27d0be492a4a936e6b30b2a16655ed3746fdd
This commit is contained in:
Fomafix
2019-05-02 06:24:44 +02:00
committed by jenkins-bot
parent 3626f06157
commit 760674d965
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
includes/UniversalLanguageSelectorHooks.php
View File

@@ -33,7 +33,7 @@ class UniversalLanguageSelectorHooks {
* @param User $user * @param User $user
* @return bool * @return bool
*/ */
public static function isToolbarEnabled( $user ) { private static function isToolbarEnabled( User $user ) {
global $wgULSEnable, $wgULSEnableAnon; global $wgULSEnable, $wgULSEnableAnon;
if ( !$wgULSEnable ) { if ( !$wgULSEnable ) {
@@ -52,7 +52,7 @@ class UniversalLanguageSelectorHooks {
* @param User $user * @param User $user
* @return bool * @return bool
*/ */
public static function isCompactLinksEnabled( $user ) { private static function isCompactLinksEnabled( User $user ) {
global $wgULSEnable, $wgInterwikiMagic, global $wgULSEnable, $wgInterwikiMagic,
$wgULSCompactLinksEnableAnon, $wgULSCompactLinksEnableAnon,
$wgHideInterlanguageLinks, $wgULSCompactLanguageLinksBetaFeature; $wgHideInterlanguageLinks, $wgULSCompactLanguageLinksBetaFeature;
@@ -106,7 +106,7 @@ class UniversalLanguageSelectorHooks {
* @param Skin $skin * @param Skin $skin
* Hook: BeforePageDisplay * Hook: BeforePageDisplay
*/ */
public static function addModules( $out, $skin ) { public static function addModules( OutputPage $out, $skin ) {
global $wgULSPosition, $wgULSGeoService; global $wgULSPosition, $wgULSGeoService;
// Soft dependency to Wikibase client. Don't enable CLL if links are managed manually. // Soft dependency to Wikibase client. Don't enable CLL if links are managed manually.
@@ -296,7 +296,7 @@ class UniversalLanguageSelectorHooks {
* Hook: ResourceLoaderGetConfigVars * Hook: ResourceLoaderGetConfigVars
* @param array &$vars * @param array &$vars
*/ */
public static function addConfig( &$vars ) { public static function addConfig( array &$vars ) {
global $wgULSGeoService, global $wgULSGeoService,
$wgULSIMEEnabled, $wgULSWebfontsEnabled, $wgULSIMEEnabled, $wgULSWebfontsEnabled,
$wgULSPosition, $wgULSNoWebfontsSelectors, $wgULSPosition, $wgULSNoWebfontsSelectors,
@@ -340,7 +340,7 @@ class UniversalLanguageSelectorHooks {
* @param array &$vars * @param array &$vars
* @param OutputPage $out * @param OutputPage $out
*/ */
public static function addVariables( &$vars, OutputPage $out ) { public static function addVariables( array &$vars, OutputPage $out ) {
global $wgULSAnonCanChangeLanguage; global $wgULSAnonCanChangeLanguage;
// Place request context dependent stuff here // Place request context dependent stuff here
@@ -369,7 +369,7 @@ class UniversalLanguageSelectorHooks {
$vars['wgULSCurrentAutonym'] = Language::fetchLanguageName( $langCode ); $vars['wgULSCurrentAutonym'] = Language::fetchLanguageName( $langCode );
} }
public static function onGetPreferences( $user, &$preferences ) { public static function onGetPreferences( $user, array &$preferences ) {
global $wgULSCompactLanguageLinksBetaFeature; global $wgULSCompactLanguageLinksBetaFeature;
$preferences['uls-preferences'] = [ $preferences['uls-preferences'] = [
@@ -399,7 +399,7 @@ class UniversalLanguageSelectorHooks {
} }
} }
public static function onGetBetaFeaturePreferences( $user, &$prefs ) { public static function onGetBetaFeaturePreferences( $user, array &$prefs ) {
global $wgExtensionAssetsPath, $wgULSCompactLanguageLinksBetaFeature, global $wgExtensionAssetsPath, $wgULSCompactLanguageLinksBetaFeature,
$wgHideInterlanguageLinks, $wgInterwikiMagic; $wgHideInterlanguageLinks, $wgInterwikiMagic;
@@ -453,7 +453,7 @@ class UniversalLanguageSelectorHooks {
* Hook: EnterMobileMode * Hook: EnterMobileMode
* @param MobileContext $context * @param MobileContext $context
*/ */
public static function onEnterMobileMode( $context ) { public static function onEnterMobileMode( MobileContext $context ) {
global $wgULSEnable, $wgULSMobileWebfontsEnabled; global $wgULSEnable, $wgULSMobileWebfontsEnabled;
// Currently only supported in mobile Beta mode // Currently only supported in mobile Beta mode