Fix-ups to comments and User interface usages

* Use isRegistered() from the more narrow UserIdentity interface.
* More specific type hints.
* Remove comments that literally repeat the code.

Change-Id: Icd0eaf8236be41b258efcf81d581540d2448e9e3

includes/Api/ApiULSSetLanguage.php

@@ -67,7 +67,7 @@ class ApiULSSetLanguage extends ApiBase {
 		}
 
 		$user = $this->getUser();
-		if ( $user->isAnon() ) {
+		if ( !$user->isRegistered() ) {
 			if ( $this->getConfig()->get( 'ULSAnonCanChangeLanguage' ) ) {
 				// Anonymous users can change language.
 				// Use a cookie that also can changed by JavaScript.

includes/Hooks.php

@@ -205,7 +205,7 @@ class Hooks implements
 		$this->statsdDataFactory->increment( 'uls.setlang_used' );
 
 		$user = $out->getUser();
-		if ( $user->isAnon() && !$out->getConfig()->get( 'ULSAnonCanChangeLanguage' ) ) {
+		if ( !$user->isRegistered() && !$out->getConfig()->get( 'ULSAnonCanChangeLanguage' ) ) {
 			// User is anon, and cannot change language, return.
 			return;
 		}
@@ -290,7 +290,7 @@ class Hooks implements
 	}
 
 	/**
-	 * @param array $preferred
+	 * @param float[] $preferred
 	 * @return string
 	 */
 	protected function getDefaultLanguage( array $preferred ) {

includes/ResourceLoaderULSModule.php

@@ -35,7 +35,7 @@ class ResourceLoaderULSModule extends ResourceLoaderModule {
 	/**
 	 * Get all the dynamic data for the content language to an array.
 	 *
-	 * @param string $languageCode Language code
+	 * @param string $languageCode
 	 * @return array
 	 */
 	private function getData( $languageCode ) {

scripts/compile-font-repo.php

@@ -1,6 +1,5 @@
 <?php
 /**
- *
  * @author Niklas Laxström
  * @license GPL-2.0-or-later
  * @file

scripts/generate-font-test-page.php

@@ -1,6 +1,5 @@
 <?php
 /**
- *
  * @author Niklas Laxström
  * @license GPL-2.0-or-later
  * @file