bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant mw.loader.using

Browse Source 
The only caller is already loading the exact same modules right
before calling these functions.

Change-Id: I71bc682f88c45e8ff20e032c7e5ee2dc3f517baf
This commit is contained in:
Niklas Laxström
2016-05-30 17:07:22 +02:00
parent 31e41a1559
commit 791cefeec6
1 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
resources/js/ext.uls.interface.js
View File

@@ -107,10 +107,7 @@
}; };
} }
$.extend( displaySettingsOptions, uls.position() ); $.extend( displaySettingsOptions, uls.position() );
mw.loader.using( mw.uls.languageSettingsModules, function () { $displaySettings.languagesettings( displaySettingsOptions ).click();
$displaySettings.languagesettings( displaySettingsOptions )
.click();
} );
} }
mw.hook( 'mw.uls.settings.open' ).fire( 'uls' ); mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );
uls.hide(); uls.hide();
@@ -131,16 +128,14 @@
languagesettings = $inputSettings.data( 'languagesettings' ); languagesettings = $inputSettings.data( 'languagesettings' );
if ( !languagesettings ) { if ( !languagesettings ) {
mw.loader.using( mw.uls.languageSettingsModules, function () { $inputSettings.languagesettings( {
$inputSettings.languagesettings( { defaultModule: 'input',
defaultModule: 'input', onClose: function () {
onClose: function () { uls.show();
uls.show(); },
}, top: position.top,
top: position.top, left: position.left
left: position.left } ).click();
} ).click();
} );
} }
mw.hook( 'mw.uls.settings.open' ).fire( 'uls' ); mw.hook( 'mw.uls.settings.open' ).fire( 'uls' );