bryce/mediawiki-extensions-UniversalLanguageSelector
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ext.uls.eventlogger: Remove unused $.Callbacks() indirection

Browse Source 
It is created, unconditionally fired only once (right after creation),
and then used only with add(), which becomes a synchronous
self-call.

I've searched in Wikimedia Git and Codesearch, and found no uses
of `logEventQueue` or `mw.uls.eventlogger` outside this file.

Change-Id: I3832bcb409fc919c2078e583d50e20413dede163
This commit is contained in:
Timo Tijhof
2018-09-06 22:45:23 +01:00
committed by Krinkle
parent 635cada69b
commit e58be7c411
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
resources/js/ext.uls.eventlogger.js
View File

@@ -27,23 +27,18 @@
* @since 2013.08 * @since 2013.08
*/ */
function ULSEventLogger() { function ULSEventLogger() {
this.logEventQueue = $.Callbacks( 'memory once' );
this.init(); this.init();
this.listen(); this.listen();
} }
ULSEventLogger.prototype = { ULSEventLogger.prototype = {
init: function () { init: function () {
var eventLogger = this;
mw.eventLog.setDefaults( 'UniversalLanguageSelector', { mw.eventLog.setDefaults( 'UniversalLanguageSelector', {
version: 1, version: 1,
token: mw.user.id(), token: mw.user.id(),
contentLanguage: mw.config.get( 'wgContentLanguage' ), contentLanguage: mw.config.get( 'wgContentLanguage' ),
interfaceLanguage: mw.config.get( 'wgUserLanguage' ) interfaceLanguage: mw.config.get( 'wgUserLanguage' )
} ); } );
eventLogger.logEventQueue.fire();
}, },
/** /**
@@ -62,11 +57,9 @@
schema = schema || 'UniversalLanguageSelector'; schema = schema || 'UniversalLanguageSelector';
this.logEventQueue.add( function () { mw.eventLog.logEvent( schema, event )
mw.eventLog.logEvent( schema, event ) .done( deferred.resolve )
.done( deferred.resolve ) .fail( deferred.reject );
.fail( deferred.reject );
} );
return deferred.promise(); return deferred.promise();
}, },