- Replacing 'mediawiki.ui/variables.less' `@import`
with new Codex design tokens as external library. We're using the
legacy values as UniversalLanguageSelector has been a desktop first
extension and those values are also used by Vector skin.
The values replaced are anyways only touching colors, borders or
transitions which are the same in normal and legacy.
These will be replaced by skin-aware 'mediawiki.skin.variables.less'
standard with dependency of UniversalLanguageSelector upped
to MW 1.42.0.
- Replacing several static values with new Codex design token featuring
skin variables, in categories `background-color`, `color`,
`border-*`, `box-shadow`, `opacity` and `transition`.
Note, that this change should result in same rendering of the
extension, only properties that already have an equal token are
replaced.
Bug: T332541
Co-Authored-by: Volker E. <volker.e@wikimedia.org>
Change-Id: Ic563fa84bf8e76fd62f14487924d7d6fd5c1a065
* Use isRegistered() from the more narrow UserIdentity interface.
* More specific type hints.
* Remove comments that literally repeat the code.
Change-Id: Icd0eaf8236be41b258efcf81d581540d2448e9e3
In f9532855ad classes were
namespaced that broke the maintenance scripts referring them.
Follow up: f9532855ad
Change-Id: I2b9658ed06cd75c25789bad8bb867e39eba6afcd
'mw' are '$' are globals, always have been, and aren't going
anywhere. They're every bit as real as their longer versions.
If anything, the longer ones are less "real" or 'stable" because
they're not used internally by RL and easier to accidentally
replace or override. For anecdotes and history, see 91f950d6b0.
Change-Id: I526fb8c961d9477992d88f2780a0ff4cbdc51923
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.
Bug: T183858
Change-Id: Id75a37eab27282ca7797fa3e6ceb92750c59477f
Use a prettifyed JSON with tabs for indenting. In non-debug mode the
whitespaces get removed by the minimizer.
Change-Id: I17f4ebabccdada3c2ad45a7e0119a4f246de0ebb
The benefit of this is that '/' is no longer escaped, making
ext.uls.webfonts.repository.js file 376 bytes smaller. I expect
that the difference in compressed size is neglible.
Change-Id: I77c0b88fa23f2245f09615c354546b6a9ebf650c
* Allow to run any directory
* Leaving stuff on /tmp was not nice
* Git pull was run on wrong directory
Change-Id: Ia7f82de55c9bd446c29afc0684660ed00b6585bf
Includes changes to the generated repository file
because the script had not been run for last update.
Change-Id: I6b5d1ce980c6e5b42e36c0044729536b6b0ae4dc
* Script: https://github.com/koalaman/shellcheck
* Use $(..) instead of deprecated `..`
* Use double quote to prevent globbing and word splitting.
Change-Id: I68372d4e29ae34e0704e5a605447ad17bf0666d7
* This avoids warnings like: line 8: cd: /tmp/jquery.ime:
No such file or directory.
* Formatting fixes.
Change-Id: Icbc3f6f80314cae3ea9b5dfdc3e66c59af225621
Files:
* Consistently have one (1) new line at EOF
(.gitignore, *.css, *.sh)
JSHint:
* Separate the common (general Wikimedia code conventions) from
the local more stricter rules (nice work!).
Maintenance:
* Use simplified $IP definition where getenv is only called once.
Based on http://git.io/ve-mw-36fc3b59-makeStaticLoader
JavaScript:
* Use the same closure in all files:
- No need for "undefined".
- One linebreak between license header and start of closure
(sometimes there were 1 or 2 empty lines).
- ext.uls.ime.js: No need for "document" (redundant in general,
but especially as it wasn't used anywhere in this file).
- Use "$, mw" for all ext.* modules (one of them used "mw, $").
Change-Id: Iba5dab14bbc3fbfc9f8fe96dd2d95529587a69aa
