This could've been done longer ago (by defining ext.uls.common
in Hooks.php), but didn't notice it before.
The ext.uls.eventlogger was (if configured) loaded on all page
loads. Same as ext.uls.init (but without config condition).
ext.uls.ext is an empty shim around ext.uls.common, which is thus
also loaded on all pages. Merge this into there given has no
reason for being its own module. They are always loaded together.
Change-Id: Icdda6f27470a1d56a37275164c06541514a488a0
The modules 'ext.uls.init'/'ext.uls.common' provides only a library and
no own funtionality. The modules get automatically loaded through
dependencies by other modules when needed as library. An explicit
loading on all page is not necessary. For example the MediaWiki API
help page does not have any ULS elements.
Bug: T145186
Change-Id: Ida99704ca2846e6adf154255bee3148e80c957d8
Given the code no longer uses any EventLogging methods directly,
but rather mw.track(), this means it also doesn't need to declare
any dependencies, including for older MediaWiki versions this
will work as-is.
Change-Id: I8cdcef54321d0887c509fc3683acf132c113e628
I guess the expectation was that for browsers that don't support
Navigator.sendBeacon, the promise would wait for the 'new Image'
fallback to complete.
However, EventLogging never did that. In browsers where the Beacon API
is not supported, 'new Image' starts asynchronously and either
way the returned promise is immediately resolved.
The only purpose of the returned promise was to detect errors
in the format of the event (e.g. missing properties), which this
code is not concerned with (given that it uses "always",
not "done"). And besides, for that you'd probably want to use
the EventLogging debug mode [1] instead.
This is the last step before ULS can switch to a soft EL dependency
by using mw.track instead, which I'll do in the next commit.
Change-Id: If016b73dcd7320ddf1478c1678d2cc6371fe0fa1
Changes:
* New tilde-based layouts for several languages of Africa:
Kabyle, Kabiye, Kikuyu, Luganda, Lingala, Malagasy,
Northern Sotho, Koyraboro Senni, Sango, Sotho, Venda
* Latin Pinyin transliteration keyboard
https://github.com/wikimedia/jquery.ime/pull/545
* CSS and JS cleanup, to switch to stylelint and eslint.
Updating to
22407cf992
Bug: T212637
Change-Id: I167e572a6cc0f7c1c727e87e8ff361d88f87b40f
This allows to change from MWException to
Wikimedia\Assert\ParameterTypeException by
I8287118cf8ec01326ead9c90a38f7b4134c3eba9.
Change-Id: Ib0cb388958cf720052ca6df73d5145b7ab3f9529
Follows-up e58be7c411, 1ad0c9c819.
* The mw.uls.eventlogger property does not appear to be
used anywhere indexed by Codesearch. It was also undocumented.
Removed without deprecation. Kept exposed for debugging purpopses
via module.exports, which could be retreived in tests via require(),
or via mw.loader.require() from the browser console.
* Remove redundant $.Deferred wrapper.
Change-Id: Id081038e5d4902c7e38967353c6f551c12517311
The hook PersonalUrls provides as third parameter an instance of the
SkinTemplate class. This provides the context.
Also fix the type of the $title parameter from string to Title in the
@param comment.
Change-Id: I35f4445292a4562718ab094bd62c0fa988abec19