Aforementioned function is faster and available since 1.21 so we
can start using it. In addition it is needed to fix T104987.
Made it so that default value is empty string instead of null
because the language validations barf at null.
Bug: T104987
Change-Id: Ie944f5c8af0c825546f9fab660451f41ab7dde3c
Error was caused because .css( 'font-family' ) returns undefined for
elements which do not exist.
Merged two blocks both extending the default settings.
Bug: 67676
Change-Id: Ic33f3934166f4feb6dd088ca0d14e249fcf237a3
Tests were failing for two reasons: wrong modules as dependencies of the
test module and test timing out due to incorrect usage of QUnit.asyncTest
and QUnit.start() and QUnit.Stop.
While at it, did some small cleanups and converted the number of
assertions to use non-deprecated QUnit.expect() instead.
Options are saved using postWithToken of mw.API. This also rises minimum
MediaWiki version to 1.22. This allowed removing hundred lines of code.
MLEB is already 1.22 and above.
Change-Id: I46a1674e4ede48a0e331c8d201d1d847db51d9dd
Not loading the "json" module either, because of backwards compatibility
and because we are likely already blacklisting browsers which don't
support json natively (mainly IE7 and older and IE8 not in standards mode)
Change-Id: I80b9eb9a7c224b5c843d42c36aca4c5e9f20c207
After seeing this wrong color dozens of times while testing svg
icons on high zooms, I can't stand the slightly different color of
the border for the caret from the rest of the ULS dialog. The border
of ULS is transparent with 0.2 alpha component over the background,
in this case I just hardcoded the resulting color here to match.
Change-Id: Ib2b2801f51ea02d2788d8703e3410eca9b3a57a3
Turns out the messages for language selector were not loading
in Special:MainPage. This fixes that as well as cleaning up the
dependencies.
Change-Id: Ice8dcf1b2e878a0fe3cd0e002a9b1cff2f1901dd
Use RL for trigger tooltip messages to avoid using jquery.i18n just
to display the triggers. Reordered dependencies so that messages
are loaded for the setting panels and ime menu.
Change-Id: Ic9518f7b63699542deb02a413e03c28344c99fa4
This does not have much effect on the gzipped payload, but it still
makes the modules look big and (I assume) take space in the local
storage.
This prefix is not used by current versions of browsers, so the only
change is that some users with old browsers get bitmap images instead
of vector images.
Instances where -moz-linear-gradient is used with colors were left in,
as were the instances in upstream libs.
Change-Id: I1515c53955467eb21c8ed70e46aecc61ab4718c2
The calculated font-height is about 13.5px on my machine. For some
reason the usage of Autonym font sways the rounding of the container
height to 14px instead of 13px as for other items. I found out that
setting line-height to 1em or 100% makes the trigger size also round
to 13px, but I can't explain why. I didn't see any change in Modern
or Monobook skins (Monobook is broken already with bold and icon
missing).
Bug: 59239
Change-Id: I71ed556f2ef707b7e5f5891d6fc0c88c01f6b0ca
* This feature is named live preview of language
* There are two scenarios in font selection feature that also
test live preview
* This test is actually making changes as well
Change-Id: I799698e08fc3d922259692de7ae0bbf5cbfd0a33
Ambiguous match of "the selected interface font must be "Systemschriftart"":
Element is no longer attached to the DOM (Selenium::WebDriver::Error::StaleElementReferenceError)
Change-Id: I74d6c8245d413dbf2819a113a19476d9b998d3c4
* Removed step which different only in case of one letter
* Removed quotes from few steps
* Fixed the scenario, but marked it as pending due to a bug
Change-Id: Iab160782e73071b543ef550dc7d86171e3636d23
Removed tags @uls-in-sidebar-only and @uls-in-personal-only.
We will figure out a better solution.
Alterted the test so that it catches if the language selector is
not visible in the viewport to catch regressions like bug 56937.
Bug: 56937
Change-Id: Ie8a37bf4f38e9c82e0c14736f2bc29e8ec1331ff
Was happening mostly on Firefox when ULS was in personal
position and you were logged out and allowed to change language.
Loading grid here already prevents graphical glitch and delaying
the click seems to prevent scrolling to wrong position.
Bug: 56937
Change-Id: Ie9acaa5a46fd903221d30c94dbc26a83355cdb64
* Do not load anything unless input field is focused
* Split the setup function to smaller functions
* Introduce $wgULSImeSelectors to allow configuration and avoid
duplication of selectors in two places.
Change-Id: If5a476e66681dde9f0b72f619d35ddf6255246ac
Removes 8 KiB from *uncompressed* initial payload
Also added missing dependency to jquery.cookie to ext.uls.init
Change-Id: If0e30d3822fa7db317d53a0a58051295da0ec0e6
* When ULS is in personal, cancel opens the language selector
again but apply doesn't.
* Created separate steps for testing the ULS trigger in personal
position, different behavior with different configuration.
Change-Id: Ifb7f101f2bfacd32c11cba69e7f2c01fe9bd9bb7
* Fixed one scenario to work with the default setting
* Fixed one typo in scenario
* Removed unused tags
* Documented the tags currently in use
Change-Id: I14687782857daf79dcd497b934dff99fc45a3997
Happens when anonymous user cannot change language, and the
language of the translation differs from the content language.
Change-Id: Ie4f15f1813eec992cfe060baf9cd7dcb5f8a0d95
There is currently some duplication between the various page objects
and other code. Those should be cleaned up incrementally.
Change-Id: I592829a00ca65bbecd5399b773c885c764c1cc06
Our logEvent wrapper now returns jQuery.Promise too.
Added timeout out parameter to our logEvent wrapper. Unlike
GettingStarted, I didn't create separate logUnlessTimeout
function.
Chrome apparently emulates enter on links as a click, so
this catches enters, left and middle clicks, but not if
the link is opened via right click menu. Might not catch
enter in all browsers.
Change-Id: I4b0eb56e7c7d6e56f8fd99d536f9b60b94a2e09e
This change introduces a new configuration variable, $wgULSEventLogging. When
set to true, ULS will register an EventLogging schema module for
<http://meta.wikimedia.org/wiki/Schema:UniversalLanguageSelector>,
making it possible to log events using `mw.uls.logEvent`. When false, the
schema module is not loaded, and `mw.uls.logEvent` is a no-op.
Change-Id: I7139e67cc2f830a6b4b3c8ff1fc72dfcdec9a699
For position=sidebar, the dummy "in other languages" section is
visible in the same manner as it is to browsers without JavaScript.
Bug: 49028
Change-Id: I931a2e904b37c754f63bfe5feb2d98bfe6c2747b