This reverts commit 5d576d05b4.
Reason for revert: Using Skin::getTemplateData method outside the
skin rendering layer is dangerous and likely a performance issue as
it means generating the rendering data twice and makes various hooks
execute multiple times.
It has caused T326538 and may be causing other issues.
Bug: T326538
Change-Id: Ie5d079deae414eb199d2a40b98d04b57439eaac4
The Compact language list preference was intended to control whether to
show all languages directly or show just a few of them (with option to
search for the rest) instead. However, with the new Vector 2022 skin,
there is only a button to access language selection and thus, this
setting should be ignored for this skin.
This patch modifies the "isCompactLinksEnabled" method inside Hooks
to always return true when the skin is set to Vector 2022 (when ULS
features are enabled).
Bug: T319690
Change-Id: Ic8a537d31ee4dad02932a04017f19537140e0c1c
The UTF-8 normalization for the URL attributes `languagecode`, `uselang`
and `setlang` are not needed.
Change-Id: Ib204629fb15e2578bba09be4c40d0210eb81dd77
I'm not sure what this is for, but it's definitely not needed
in Vector 2022 skin. It also prevents the uls-after-portlet-link
element from appearing inside the language button when ULS is disabled.
Bug: T275147
Change-Id: I8f6c1361040b72107f2d45bfc18e22d6b8f2021c
* Use isRegistered() from the more narrow UserIdentity interface.
* More specific type hints.
* Remove comments that literally repeat the code.
Change-Id: Icd0eaf8236be41b258efcf81d581540d2448e9e3
Stop additional conditional hook if MW < 1.37, and move the check
to inside the hook itself
Bug: T299305
Change-Id: Ied1c5c0beee015d7b0a8d6bd750346f4a8a5aaa1
