Following on from I6fa966c2, fire the mw.uls.compact_language_links.open
hook with the $trigger parameter as context for clients to be able to
able to distinguish which treatment is visible to the user.
Supporting changes:
- Note that the hook is unstable next to its callsite
Bug: T280770
Change-Id: Ie4bbfea4dc5e36401df587550f466aeae5c8fdcc
extension.json configuration should reflect recommended production
configuration whenever possible. This particular configuration flag
is only ever true on Russian Wikivoyage or Wikisource, so is more
often false than true.
Having this default would have saved me ten minutes trying to work
out how to make the preference available, so I am keen to save someone
else that time in future.
Bug: T282149
Change-Id: Ieef58631c7ef5c42ffc05f13d0ed8a4f02c48de1
jquery.uls:
* Make "ha" the primary code for Hausa (should address Bug T279269).
* Localisation updates: ms-arab, ce, fur.
* Minor whitespace fixes for eslint.
Updating to
9b879ca89b
jquery.ime:
* Minor whitespace and escaping fixes for eslint.
Updating to
1fd57c64b9
Bug: T279269
Change-Id: I46aeb0a8397ebd9dc8a5d68a9e92368d8156ae2d
* $(node).prop(foo) -> node.foo
* For objects only expected to represent a single element,
use native querySelector() and its natural null return
fallback, instead of `$(), $.length, $()` etc.
* Fix a few minor non-voting eslint warnings that were in the CI
output about line length and unknown type "bool".
* Remove presumed outdated comment about Vector splitting,
per T234907.
* Rename ulsPosition to configPosition to be more clearly
different from ulsPopupPosition.
* Remove various 'uls' prefixes of local variables,
since this is ULS code in the ULS repository.
Change-Id: I1c617bf48283f47dc948550111c515faf173d1eb
Due to the nature of the script, Tiben usually has high ascent and descent
values. Use a variant of BabelStoneTibetan to have lesser ascent, descent
values for modern, frequently used Tibetan
Bug: T283122
Change-Id: I902af894b0e4d6f375981f13548be49405fb3602
Jomolhari is inactive upstream for years and BabelStone is an active
fork with improvement for better script support.
Bug: T197596
Change-Id: I5c3c1ce5ad2a80c78e93304d4023342a66382942
Following on from Icc64044d, we fire the
mw.uls.compact_language_links.open hook whenever that treatment is
opened (and not only the first time that the triggering element is
clicked).
Bug: T281928
Change-Id: I6fa966c22c738ca12bcbeb0225c03f3f8394ecee
This allows us to correctly instrument (via the
UniversalLanguageSelector instrument) this action so interaction rates
between treatments can be compared.
Bug: T273232
Bug: T273928
Change-Id: Icc64044d51c567482d4f286637366cefb7beeb3e
The filterForCommonLanguagesForUser method checks if commonInterlanguageList
is null, but it can never be null unless it is first initialized that
way.
Bug: T282037
Change-Id: I70c3a60349693473509d9b329764dc5138930506
In modern Vector, the ULS trigger button has a child node which is
a span. When clicks are received on the span, they will result
in positioning relating to the span rather than the button.
The ev.currentTarget should be read outside the asynchronous function
to avoid bubbling.
Bug: T276248
Change-Id: I6e138c88e29b335b8e0bc22cf0aa07c289a5eb74
These ignores are already in package.json. Placing these here was
making `npm test` wait 10-20 seconds doing nothing waiting for Grunt
to synchronously recursively glob and expand an array of every file
in the current working directory (incl node_modules, and vendor) and
then once more for node_modules and vendor, and then to filter one
out from the other. And all before eslint even starts.
Instead, give '.' to eslint as we do in some other repos already,
and let it iterate on its own, skipping sub directories as it goes
based on package.json/eslintIgnore.
This follows-up 445087e5f, which did this once before,
and be400fe75 which unintentionally brought the Gruntfile part
back while leading the other part behind.
Change-Id: If637f2a696326778f25ea208224f5ac101f8c64a
The ulsPopup variable is local to the showUndoTooltip() function.
If it is called multiple times, then a previous assignment of an
OO.ui.PopupWidget object would not be found here in subsequent calls.
This check can only ever be false since it is the first statement in
the function (after variable and function declarations, which don't
do anything other than call `$()`).
Change-Id: I7020c103428d01b5e48c65be695471401f588fc4
