ext.uls.interface: remove unused "ulsPopup remove" code
The ulsPopup variable is local to the showUndoTooltip() function. If it is called multiple times, then a previous assignment of an OO.ui.PopupWidget object would not be found here in subsequent calls. This check can only ever be false since it is the first statement in the function (after variable and function declarations, which don't do anything other than call `$()`). Change-Id: I7020c103428d01b5e48c65be695471401f588fc4
This commit is contained in:
@@ -159,10 +159,6 @@
|
||||
tipsyTimer = setTimeout( hideTipsy, timeout );
|
||||
}
|
||||
|
||||
// remove any existing popups
|
||||
if ( ulsPopup ) {
|
||||
ulsPopup.$element.remove();
|
||||
}
|
||||
if ( ulsPosition === 'interlanguage' ) {
|
||||
if ( $ulsTrigger.offset().left > $( window ).width() / 2 ) {
|
||||
ulsPopupPosition = 'before';
|
||||
|
||||
Reference in New Issue
Block a user