Commit Graph
100 Commits
Author SHA1 Message Date
Niklas Laxström ded20c61f2 Fix and enable feature Persistent settings
* Reuse existing steps where possible
* Rename steps file to match convention
* Moved unrelated steps to a new file
* Added wait for saving

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3822

Bug: 56885
Change-Id: I480058430696579947187265b940ea46156f1519
2013-11-21 11:08:08 +02:00
Niklas Laxström f884356c15 Refactor "Edit area should use the fonts selected by the user from ULS for a language"
* Removed step which different only in case of one letter
* Removed quotes from few steps
* Fixed the scenario, but marked it as pending due to a bug

Change-Id: Iab160782e73071b543ef550dc7d86171e3636d23
2013-11-13 12:45:46 +02:00
Niklas Laxström cffbe79195 Refactor "Open language selector when logged in"
Removed tags @uls-in-sidebar-only and @uls-in-personal-only.
We will figure out a better solution.

Alterted the test so that it catches if the language selector is
not visible in the viewport to catch regressions like bug 56937.

Bug: 56937
Change-Id: Ie8a37bf4f38e9c82e0c14736f2bc29e8ec1331ff
2013-11-13 11:51:04 +02:00
Niklas Laxström de4f78a6be Use data-i18n for system font l10n
This ensures that the translation is updated properly in the
language live preview.

Bug: 56888
Change-Id: I320c570f9272e8d191144f66a9cf0079c89d201d
2013-11-13 08:36:47 +00:00
Niklas Laxström 7822d5d03b Page scrolls when opening language selector
Was happening mostly on Firefox when ULS was in personal
position and you were logged out and allowed to change language.

Loading grid here already prevents graphical glitch and delaying
the click seems to prevent scrolling to wrong position.

Bug: 56937
Change-Id: Ie9acaa5a46fd903221d30c94dbc26a83355cdb64
2013-11-12 12:50:31 +00:00
Nikerabbit 2bc77f2c18 Revert "Do not load jquery.jStorage for logged in users"
This reverts commit 5884337c9f.

Change-Id: Icfdfd89059a417a6aaea30d12164e7174dd5f58b
2013-11-12 12:47:56 +00:00
Niklas Laxström 5884337c9f Do not load jquery.jStorage for logged in users
Change-Id: Ibe77962cecd6aa8504aa60d5d2b8d17a56e1319f
2013-11-12 10:40:59 +00:00
Niklas LaxströmandSanthosh Thottingal bd52ae0538 ResourceLoaderULSModule::getModifiedTime updates continuously
Fix is simple: cache the hash of content per language

Added PHPUnit test for the same

Bug: 56856
Change-Id: I590b27af220d6e790c70728062d1a04c098b3d11
2013-11-11 16:12:07 +05:30
Niklas LaxströmandSanthosh Thottingal 193f69b017 Refactor ime lazy loading
* Do not load anything unless input field is focused
* Split the setup function to smaller functions
* Introduce $wgULSImeSelectors to allow configuration and avoid
  duplication of selectors in two places.

Change-Id: If5a476e66681dde9f0b72f619d35ddf6255246ac
2013-11-05 16:48:47 +05:30
Niklas LaxströmandNemo bis 0423290ec3 Delay loading of jquery.uls.grid until needed
Change-Id: I790333ac03a4103bed757867acfd1b44a7e00525
2013-11-01 11:39:28 +00:00
Niklas Laxström 3d3152df8e Move button styles to separate module
Removes 8 KiB from *uncompressed* initial payload

Also added missing dependency to jquery.cookie to ext.uls.init

Change-Id: If0e30d3822fa7db317d53a0a58051295da0ec0e6
2013-11-01 09:52:30 +00:00
Niklas LaxströmandAmir E. Aharoni 967683c98e Refactoring Input method menu is not offscreen
Change-Id: Iff83160eb6c99d6109098e431341240a21274665
2013-10-31 13:47:04 +02:00
Niklas Laxström 3398a949e3 Refactor Sticky input methods
Change-Id: I20ee4e7b90ec9aaa3155fe2e357cf04388d0994c
2013-10-30 11:50:13 +02:00
Niklas LaxströmandAmire80 891b6977ce Refactoring Applying the live preview of interface font
We renamed get*font to just *font

Change-Id: Ib6992849a2bf927d2e2d465231df58857e506a62
2013-10-29 14:07:45 +00:00
Niklas LaxströmandAmire80 b47a8ac5d3 Refactoring Discarding live preview of interface font
Includes fix for content font as well

Change-Id: Ie97c5d45c6613889975ca6af59c6bd0856d331dc
2013-10-29 14:05:53 +00:00
Niklas Laxström 52372f5857 Refactoring ime tests
Scenarios:
* Input method menu
* Input method indicator is shown
* Unsupported input language (pending)

Added IMEPage

Change-Id: I1f68d177bd05baca6ae8da97364b81a4d851b8b6
2013-10-28 13:29:31 +02:00
Niklas LaxströmandZeljko Filipin 48a5772e9e More refactoring ULS font selection tests
Change-Id: I6595e279657948265c45407be2c01a4587fdbc94
2013-10-25 11:30:47 +02:00
Niklas Laxström a5c7b43282 Refactoring of ULS font selection tests
Change-Id: Ie4d5843f76bff277750a2d61a13b3297650e52f7
2013-10-23 12:33:33 +03:00
Niklas LaxströmandZfilipin 06a386fa83 This scenario does not work with anon language selection
Change-Id: Ia54d6de807e81ccbbd062633a49ec7313c869fa7
2013-09-18 00:41:46 +00:00
Niklas Laxström 12f7f84edd Fix the test I broke
Change-Id: I3f8181f84b387ab811f5efc16c734800e3639a15
2013-09-17 16:40:52 -07:00
Niklas Laxström 3fc1c3299c Simplify tests
Change-Id: Ide435d4d11e9ab03c953ed91e949d55e46c5137e
2013-09-17 15:16:52 -07:00
Niklas Laxström 2d62e3e7f7 Simplify test code
Change-Id: I65c3edc85ee8619c7e77cca7622e7025799bdcad
2013-09-17 14:38:16 -07:00
Niklas Laxström f43a00d5b8 Refactoring tests
Collaboratively

Change-Id: I6c5417a0681f9bb8596c36600a569df2ddd7bf9e
2013-09-16 15:55:51 -07:00
Niklas LaxströmandNemo bis e36d9b1cc3 Regression: Using [...] to change language does not activate apply button
Bug: 53736
Change-Id: If52beb73f9f3f74cde63bd846974540682066ab6
2013-09-04 07:00:53 +00:00
Niklas Laxström bcb2dd8b82 Make more tests pass in sandbox.translatewiki.net
* When ULS is in personal, cancel opens the language selector
  again but apply doesn't.
* Created separate steps for testing the ULS trigger in personal
  position, different behavior with different configuration.

Change-Id: Ifb7f101f2bfacd32c11cba69e7f2c01fe9bd9bb7
2013-09-04 09:37:28 +03:00
Niklas Laxström 975e69d880 Cleanup and add documentation for tags
* Fixed one scenario to work with the default setting
* Fixed one typo in scenario
* Removed unused tags
* Documented the tags currently in use

Change-Id: I14687782857daf79dcd497b934dff99fc45a3997
2013-09-02 17:14:25 +03:00
Niklas Laxström 34146ea023 (bug 49738) Use correct name for wiki content language
Happens when anonymous user cannot change language, and the
language of the translation differs from the content language.

Change-Id: Ie4f15f1813eec992cfe060baf9cd7dcb5f8a0d95
2013-08-30 12:45:02 +03:00
Niklas Laxström b90208affc New scenario: Discarding a live preview of a font keeps the previous font
Change-Id: I4dbd90263be5a35c654b850e6c3632959e8a3915
2013-08-30 12:18:26 +03:00
Niklas Laxström 53f19e9f70 Add test for language live preview cancellation
Change-Id: I4880667df23301f4235a05df575fb84554c17303
2013-08-30 10:47:01 +03:00
Niklas Laxström 773b8f42e6 Fix more tests for phantomjs
As a bonus got rid of JavaScript call.

Refactored uls-position code to a method.

Change-Id: I1df384a02909d430c12225525d5722a0520177ee
2013-08-30 10:47:01 +03:00
Niklas Laxström 54afab7ffc Assert that the login succeeded for more helpful error messages
Change-Id: I9f985d31de86fe2a062d10ca3f51fb2d7c727798
2013-08-30 10:47:01 +03:00
Nikerabbit ef826e0e75 Simplify the cancel logic for input and display settings
Change-Id: I2afe78edad31b00a35d0589384e4091b61091275
2013-08-29 10:57:45 +00:00
Niklas Laxström a6e3ec586e Make tests pass in phantomjs
Change-Id: I0cb094b8a350b716cfb7b50ea6e370fd39fff1d6
2013-08-28 18:44:23 +03:00
Niklas Laxström 2a6ae9f162 More refactoring of tests per feature
Change-Id: Ie9acf09f9bb992f6e03ff6dfbb80e1e20a9d43ca
2013-08-28 14:56:24 +03:00
Niklas Laxström 3bd4bb4f03 Refactor ULS tests to reduce duplication and repetition
Change-Id: I96f1594f1b4d1960da9a8bc21e2a5c4727497b10
2013-08-28 14:08:17 +03:00
Niklas LaxströmandAmir E. Aharoni d695b21381 Add new scenarios for font changes
There is currently some duplication between the various page objects
and other code. Those should be cleaned up incrementally.

Change-Id: I592829a00ca65bbecd5399b773c885c764c1cc06
2013-08-27 16:35:23 +03:00
Nikerabbit 537e6def5d Revert "Simplify the cancel logic for input and display settings"
This reverts commit a5d79594a3.

Causes new integration tests to fail.

Change-Id: I7e14d73d0d726a3253e8c6e6bdf5066230d8454c
2013-08-27 12:34:50 +00:00
Niklas Laxström 7f8f1136e8 Add gitignore and remove unsupported browsers
Change-Id: Ic415bcee0cfa8822a48396a2c1b086dbff200c2a
2013-08-27 14:03:47 +03:00
Niklas LaxströmandSanthosh Thottingal ec518a03b4 Provide mw.hook when not provided by older MediaWikis
Change-Id: I8d0826722064551cc46be26215ffb954f39babb0
2013-08-22 09:46:07 +05:30
Niklas Laxström 3a6e5d312a Code conventions
Change-Id: I0f58d4675cf26050ea1e2f58fb748e0aed74b54d
2013-08-20 05:34:16 +00:00
Niklas Laxström 1f66cb22bc Log no-search-results event
Change-Id: Ia272a6783d56c75ba775d71195104aad21214121
2013-08-19 08:13:55 +00:00
Niklas LaxströmandAmir E. Aharoni df18f0a5ff Log settings-open event
Change-Id: I55fb9e4b8b6b210003f6bbad07486e1c2a8cba4f
2013-08-05 15:19:57 +08:00
Niklas Laxström 0af4375e7c Fix spelling mistake in variable name
Change-Id: I791555dc4a04beb6109e212314f8f4747fc8b6d9
2013-08-05 04:04:19 +00:00
Niklas Laxström 425709cdb3 Log language-change for interface language
Change-Id: Icf8067078043be0f3a1c4f2c645835d88414b616
2013-08-02 13:43:18 +00:00
Niklas LaxströmandAmire80 e8479a070d Log ui-lang-revert
Change-Id: Ic48dbd7a9d4d43812f437e3c9f17d1ee208166e8
2013-08-02 13:14:27 +00:00
Niklas Laxström 8e1726e745 Log login-click event
Our logEvent wrapper now returns jQuery.Promise too.

Added timeout out parameter to our logEvent wrapper. Unlike
GettingStarted, I didn't create separate logUnlessTimeout
function.

Chrome apparently emulates enter on links as a click, so
this catches enters, left and middle clicks, but not if
the link is opened via right click menu. Might not catch
enter in all browsers.

Change-Id: I4b0eb56e7c7d6e56f8fd99d536f9b60b94a2e09e
2013-08-02 13:03:15 +00:00
Niklas LaxströmandAmire80 883e87ea56 Help links for ime selector menu
Change-Id: Ia6a0db9af25216f3d03c5130de96000141ccaa57
2013-07-15 13:24:12 +00:00
Niklas Laxström da1baaf663 Help links for input settings
Bug: 42373
Change-Id: I30c8d6cbe916ac026ad70974755942c5bbea7162
2013-07-15 11:08:17 +00:00
Niklas LaxströmandSanthosh 034acf6f0f Log ime-enable and ime-disable events
Change-Id: I96964cb190d1a67bba536458ebadd3bd677d4fa6
2013-07-06 12:26:52 +00:00
Niklas Laxström c51384e4e1 Use /** for method documentation blocks
Change-Id: I6c7a8b7c2e2e861120caa1f1b5ff9b0dc7537737
2013-07-06 10:33:12 +00:00
Niklas Laxström 4543d43dda Prepare ULS for EventLogging
This change introduces a new configuration variable, $wgULSEventLogging. When
set to true, ULS will register an EventLogging schema module for
<http://meta.wikimedia.org/wiki/Schema:UniversalLanguageSelector>,
making it possible to log events using `mw.uls.logEvent`. When false, the
schema module is not loaded, and `mw.uls.logEvent` is a no-op.

Change-Id: I7139e67cc2f830a6b4b3c8ff1fc72dfcdec9a699
2013-07-02 12:47:22 +00:00
Niklas Laxström 10c1177c1d Remove comma that shouldn't have been introduced
Change-Id: Iaf24bc1cf4ec59fe2c44601eee1a19ccdac757ba
2013-06-19 18:19:42 +00:00
Niklas Laxström d9883c90d7 Remove border-radius from ULS cog
Per http://stackoverflow.com/questions/11114636/opera-border-radius-svg-background-bug

Bug: 49379
Change-Id: I197e9e9a8c5afcefc998e302329aa96dc2df33da
2013-06-19 09:54:34 +00:00
NikerabbitandGerrit Code Review 1972f02148 Merge "Update jquery.ime from upstream" 2013-06-10 07:31:20 +00:00
Niklas Laxström 0c53c38304 Hide ULS trigger from unsupported browsers
For position=sidebar, the dummy "in other languages" section is
visible in the same manner as it is to browsers without JavaScript.

Bug: 49028
Change-Id: I931a2e904b37c754f63bfe5feb2d98bfe6c2747b
2013-06-04 10:26:57 +00:00
Niklas LaxströmandGerrit Code Review 979c2da418 Workaround for border-radius due to bug 49074
Change-Id: I411ea2cda0fcfc0c3182189ed6dc2f25851cd04c
2013-06-04 09:31:51 +00:00
Niklas Laxström 15b57bc315 Fix some incorrect hook annotations
Change-Id: I2594b50c07eafbee68df29152066c81a79035a9e
2013-05-25 08:43:27 +00:00
Niklas Laxström d10f685eb9 Remove unused resources
Change-Id: I80eb3dc02e99fd0dda5990a3a690d897e054cfcd
2013-05-24 18:51:28 +00:00
Niklas Laxström 6705754c75 Optimize images
Change-Id: I8cf0ec50425374e8abb89dcedc9663375e3d1edd
2013-05-22 09:16:42 +00:00
Niklas LaxströmandSanthosh Thottingal 142bdbd7c7 Better way to fix jslint warnings
Change-Id: Id56aa9c742bdd5dd7cec5848d1b44a4dafaca9c0
2013-05-22 09:41:20 +05:30
Niklas LaxströmandAmir E. Aharoni 2f4e9cfff9 Reduce rerenderings in input settings
Change-Id: Ia929bbbb2cd6be18e37d9b73b4eea199bd0ad4b8
2013-05-09 16:28:21 +03:00
Niklas Laxström f275dbeb98 I18n for System font
Bug: 47819
Change-Id: I9244aab0ec32c27bfc56dd5a441f02a9783e5fb1
2013-05-03 08:43:08 +00:00
Niklas Laxström 065948182c Fix tipsy behaviour
* Make it visible in interlanguage position
* Do not get stuck in no-tooltip state if previous lang is invalid

Change-Id: Iaf5727a8a729579c2a0c79d0e0dc49d58bbf66ea
2013-04-29 13:07:31 +00:00
Niklas Laxström aee1fcff19 Join some appends to one call
Change-Id: Iccf4c7653aff775a6ea0ddc211135dab8b1d99d1
2013-04-29 12:20:42 +00:00
Niklas Laxström d309c687e9 Rename confusingly named function
Change-Id: I685a1658ec911e28cba4c9d3d7cbaaf4f1cca22e
2013-04-29 12:20:42 +00:00
Niklas LaxströmandGerrit Code Review 4554c79d51 Load ULS language list from a resource loader module
Having them in the page source of every page view is wasteful.

Bug: 41210
Change-Id: If15e297a4781cc49ded06fbc906529f57a22aafe
2013-04-28 11:26:40 +00:00
Niklas LaxströmandAmir E. Aharoni 60242e2c53 Use wmf geoip by default
Unlike freegeoip it also works with https

Also moved the getCountryCode function to init, as it should be
available regardless of whether we load the optional geoclient
module.

Bug: 40965
Change-Id: Ia18130890d09f86a93b5b61f7da7c48fcfa480c7
2013-04-28 14:25:26 +03:00
Niklas Laxström da255cdc77 Fix Undefined offset notice
Also removed some dead code that never ran, there is no variable named
"$buckets" so it'll never have an offset.

Bug: 45327
Change-Id: I1f70ef0ec4f2434f9f072e718140ff8050b81ba3
2013-04-26 14:29:08 +00:00
Niklas LaxströmandNemo bis 6b143320ad Introduced $wgULSAnonCanChangeLanguage
This allows us to enable web fonts and input methods for all
users by disabling just the interface language selection.

Updated the documentation of the variables to make it clearer
what each does. Summary:
* Enabling: $wgULSEnable and $wgULSEnableAnon
* Workarounds: $wgULSAnonCanChangeLanguage and $wgULSLanguageDetection

Cleaned up hooks, in particular rewritten getLanguage to separate
the logged in vs. logged out steps for easier understanding.

A followup commit is needed to disable language selection UI for
anon if $wgULSAnonCanChangeLanguage is false.

Change-Id: Ia8d21c394ff5efac0ce94664710c97dc3b74ec18
2013-04-26 12:21:23 +00:00
Niklas Laxström e34163b9d3 Consistency changes
Change-Id: Id5c62940ef7084b97573cfd62974f3bc27dd418a
2013-04-10 12:52:14 +00:00
Niklas Laxström 977640a40f Add $resourcePaths
Change-Id: I2b3ef5f57566fe5bcc6549157e09c47fdc61e95f
2013-04-03 11:13:52 +00:00
Niklas Laxström 9692a17671 Sort modules alphabetically
Change-Id: Id8a0daabe6204e2a4c52d702e29d891fd80b89ae
2013-03-28 11:11:18 +00:00
Niklas LaxströmandSanthosh Thottingal 7158b0adeb Add separate Resources.php
Change-Id: Ie02fbdd1bb8a1c83f66eacff8de0ca0bd6c67ab4
2013-03-27 15:09:59 +05:30
Niklas Laxström 00189afa66 Add ext.uls.geoclient back to deps
Change-Id: I4e1aa22edd89ff666b29c7b26c1928885e8bc896
2013-03-26 10:18:44 +00:00
Niklas Laxström 1c383fb8f9 Optimize pngs
Change-Id: I8666484a23228358a5f4ece449123c6458bb76d1
2013-03-13 09:53:48 +00:00
Niklas Laxström dfcade7f69 Update to match core changes in Idc11b547
Change-Id: I5481df33c7056cf2c661527f6ed3cf2374b6a0bf
2013-01-18 08:25:40 +00:00
Niklas Laxström 9b72969b07 (bug 44010) Try to avoid messing wrong request contexts
Also takes use of $request parameter if given, but does
not depend on Idc11b547

Change-Id: I870281f26cbc87c43d9b2a763f78c5756cb2327f
2013-01-16 09:55:48 +00:00
NikerabbitandGerrit Code Review e7d1965f7c Merge "Whitespace" 2013-01-02 07:47:55 +00:00
NikerabbitandGerrit Code Review 3555303dd6 Merge "Add Kannada Gubbi font to repo, replace Kedage" 2012-11-26 08:46:32 +00:00
NikerabbitandGerrit Code Review 018b999328 Merge "Just hide the whole window after apply button pressed" 2012-11-21 07:21:43 +00:00
NikerabbitandGerrit Code Review 8882e7b08d Merge "Updated webfonts test page with bold, italic, underline options" 2012-11-20 07:43:21 +00:00
NikerabbitandGerrit Code Review 7ef3d7864b Merge "Update docs" 2012-11-13 10:37:40 +00:00
Niklas LaxströmandGerrit Code Review 3c9e7249a8 Geoclient fixes for https and WMF
* Don't call freegeoip on https, it wont work
* Use Geo instead of GEO like WMF

Change-Id: I9ebdd9f3518e15e70122a9c8c8d64240d5e44c5b
2012-11-10 07:15:07 +00:00
NikerabbitandGerrit Code Review 9636137e50 Merge "Fix Bug 41804 - Display Settings shows dual labels for Font Selection" 2012-11-09 16:44:41 +00:00
Niklas Laxström 4b811a5997 Avoid contstructing html with concatenation
Fixes potential security issue, bug 41395.
Change-Id: I55c79e41de6084d18c49b8bb715a7f49e19dc7e9
2012-11-01 12:25:27 +00:00
Niklas LaxströmandSanthosh Thottingal 25889d77b6 Avoid constructing html with concatenation
Change-Id: I6104ade6a9f9209df921577cd04d7fe9487e65d9
2012-11-01 17:26:10 +05:30
Niklas Laxström 8529ed7377 Guard for web execution
Change-Id: I4cac7035a9b80865c3ff5a709f5d7d7c5e5cada4
2012-10-26 19:35:00 +00:00
NikerabbitandGerrit Code Review 4c26d822f2 Merge "Simplify the preference system" 2012-10-24 15:54:33 +00:00
NikerabbitandGerrit Code Review 488d4bae45 Merge "Removed "Select prefered font" heading" 2012-10-12 19:31:39 +00:00
NikerabbitandGerrit Code Review 4709c97fd4 Merge "Make the previous language link work" 2012-10-02 07:28:34 +00:00
NikerabbitandGerrit Code Review f78ee750e8 Merge "Respect the system default font for languages" 2012-10-02 07:25:29 +00:00
Niklas Laxström ceb1a80eea ext.uls.geoclient should not break if it runs before ext.uls.init
Change-Id: If4c8203bccd4287a94de6b22210f067852241614
2012-09-09 07:55:23 +00:00
NikerabbitandGerrit Code Review d29364989f Merge changes I83d4808a,If8ea8c1f
* changes:
  JsHint fixes - Move the invocation into the parens that contain the function.
  Fix Bug 39096 - Narayam compatibility with ULS
2012-09-07 11:07:10 +00:00
Niklas LaxströmandGerrit Code Review 01b41b9783 Message consistency
* Removed title case
* "language used for menus"

Change-Id: If5c0323f5e49f2e71a3b6257b62ce5a08c74704c
2012-09-03 09:10:08 +00:00
Niklas Laxström dc163127e3 Language detection was overriding language for logged in users
Change-Id: I491e429b6ea352c67bdc3b63acf191e187059fde
2012-09-01 19:09:40 +00:00
NikerabbitandGerrit Code Review be20d2f6e1 Merge "Filtering out languages that the ULS doesn't recognize" 2012-08-31 10:49:56 +00:00
Niklas LaxströmandGerrit Code Review b1fad2c1bb I18n#1473: Use preferred language for anonymous users
Change-Id: I25833bb4c35453bbb055b4782d996604c93ef7db
2012-08-31 10:31:11 +00:00
Niklas Laxström 99d3d152b4 Added/fixed some sami languages
Names taken from (en|fi).wiktionary.org

Change-Id: I6b08417e9a9d65753028d6c5f151b89485542484
2012-08-30 14:35:48 +00:00
Niklas Laxström d738b0f117 JS cleanup
Change-Id: I804d9f5e13f0c186da19cd31eae5156277f0f0d4
2012-08-30 13:56:04 +00:00
NikerabbitandGerrit Code Review ad2dfcacd6 Merge "Sort language names in the landing page" 2012-08-30 13:52:11 +00:00