Merge "LanguageSettings: Do not render modules twice on initialization"

2016-08-16 10:03:00 +00:00
parent ab8193faac 5e7e8fe48e
commit f44d97230b
1 changed files with 4 additions and 4 deletions
--- a/resources/js/ext.uls.languagesettings.js
+++ b/resources/js/ext.uls.languagesettings.js
@@ -139,6 +139,10 @@
 					$settingsText
 				);

+			if ( active ) {
+				$settingsLink.addClass( 'active' );
+			}
+
 			$settingsMenuItems.append( $settingsLink );

 			$settingsLink.on( 'click', function () {
@@ -151,10 +155,6 @@
 				$this.addClass( 'active' );
 			} );

-			if ( active ) {
-				module.render();
-				$settingsLink.addClass( 'active' );
-			}
 			this.modules[ moduleName ] = module;

 			// Register cancel and apply hooks